SC query service dispatcher #2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
Jan 7, 2021
iulianpascalau
commented
- added scQueryServiceDispatcher functionality that can launch a specified number of VMs used in query service and will route each and every request to such generated SC query service in a round-robin fashion
…ified number of VMs used in query service and will route each and every request to such generated SC query service in a round-robin fashion
sasurobert
requested changes
Jan 7, 2021
cmd/node/main.go
Outdated
| ) (process.SCQueryService, error) { | ||
| numConcurrentVms := generalConfig.VirtualMachine.Querying.NumConcurrentVms | ||
| if numConcurrentVms < 1 { | ||
| return nil, fmt.Errorf("VirtualMachine.Querying.NumConcurrentVms should be a positive number higher than 1") |
There was a problem hiding this comment.
more than equal instead of "higher"
cmd/node/config/config.toml
Outdated
| @@ -625,7 +625,8 @@ | |||
| MessagesMarshalizer = "json" | |||
| MaxLoopTime = 1000 | |||
| [VirtualMachine.Querying] | |||
| OutOfProcessEnabled = false | |||
| OutOfProcessEnabled = true | |||
There was a problem hiding this comment.
we could simply delete from here OutOfProcess and have it default on true directly when creating the scquery service
There was a problem hiding this comment.
good idea, will hardcode it to true
sasurobert
previously approved these changes
Jan 7, 2021
added trace log for invalid transaction
sasurobert
previously approved these changes
Jan 7, 2021
bogdan-rosianu
requested changes
Jan 7, 2021
bogdan-rosianu
previously approved these changes
Jan 7, 2021
sasurobert
previously approved these changes
Jan 7, 2021
LucianMincu
previously approved these changes
Jan 7, 2021
andreibancioiu
dismissed stale reviews from LucianMincu, sasurobert, and bogdan-rosianu
via
07685a3
sasurobert
approved these changes
Jan 7, 2021
bogdan-rosianu
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.