Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update/sync: add missing continue #2670

Merged
merged 2 commits into from Jan 11, 2021
Merged

update/sync: add missing continue #2670

merged 2 commits into from Jan 11, 2021

Conversation

zhiqiangxu
Copy link
Contributor

@zhiqiangxu zhiqiangxu commented Jan 10, 2021 •
edited by iulianpascalau

  • Added missing continue statements on for loops

sasurobert
sasurobert previously approved these changes Jan 10, 2021
View reviewed changes
@zhiqiangxu
Copy link
Contributor Author

zhiqiangxu commented Jan 10, 2021 •
edited

found a similar issue in syncMiniBlocks :)

I've a question about MiniBlockHeaders though, are intra-shard MiniBlockHeader also recorded in MetaBlock, or just cross-shard ones?

sasurobert
sasurobert previously approved these changes Jan 10, 2021
View reviewed changes
@iulianpascalau iulianpascalau changed the base branch from development to external January 11, 2021 09:43
@iulianpascalau iulianpascalau dismissed sasurobert’s stale review January 11, 2021 09:43

The base branch was changed.

@iulianpascalau iulianpascalau merged commit c53fe61 into multiversx:external Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdoAdoAdo AdoAdoAdo AdoAdoAdo approved these changes

@iulianpascalau iulianpascalau iulianpascalau approved these changes

@sasurobert sasurobert sasurobert left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhiqiangxu @sasurobert @AdoAdoAdo @iulianpascalau