Fixed misleading info about cross-shard miniblocks processing #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SebastianMarian
commented
Jan 13, 2021
•
SebastianMarian
commented
- Fixed misleading info about number of txs processed for a cross shard miniblock when an error is occured ("time is out" or any other error)
…miniblocks when an error is occured ("time is out" or any other error)
sasurobert
previously approved these changes
Jan 13, 2021
ccorcoveanu
reviewed
Jan 13, 2021
| } | ||
|
|
||
| processedTxHashes := make([][]byte, 0) | ||
| for index := range miniBlockRewardTxs { | ||
| if !haveTime() { | ||
| return processedTxHashes, process.ErrTimeIsOut | ||
| return processedTxHashes, len(processedTxHashes), process.ErrTimeIsOut |
There was a problem hiding this comment.
Maybe I'm missing something, but isn't the second returned parameter always len(processedTxHashes) (or index in the following cases below)?
There was a problem hiding this comment.
Yes, you are right
sasurobert
previously approved these changes
Jan 13, 2021
sasurobert
approved these changes
Jan 13, 2021
ccorcoveanu
approved these changes
Jan 13, 2021
valentincraciun99
approved these changes
Jan 13, 2021
LucianMincu
deleted the
Fix-misleading-info-about-cross-miniblocks-processing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.