Gas schedule fine tuning #2690
Merged
Gas schedule fine tuning #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
Jan 13, 2021
•
iulianpascalau
commented
- adjusted CryptoAPICost gas costs & AoT gas cost
sasurobert
previously approved these changes
Jan 16, 2021
| @@ -68,7 +68,7 @@ | |||
| ExecuteOnDestContext = 160000 | |||
| DelegateExecution = 160000 | |||
| AsyncCallStep = 200000 | |||
| AsyncCallbackGasLock = 20000000 | |||
| AsyncCallbackGasLock = 2000000 | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
yes. it was way too much. we have an additional dynamic gas lock depending on the size of the contract. which gets accumulated with this.
| @@ -1,7 +1,7 @@ | |||
| [BuiltInCost] | |||
| ChangeOwnerAddress = 5000000 | |||
| ClaimDeveloperRewards = 5000000 | |||
| SaveUserName = 5000000 | |||
| SaveUserName = 1000000 | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
yes. it is a simple save which will come through the DNS contract which already consumes around 14-15 million gas. plus async call gas.
| AoTPreparePerByte = 200 | ||
| GetCode = 100000 | ||
| AoTPreparePerByte = 300 | ||
| GetCode = 1000000 |
There was a problem hiding this comment.
yup, according to our tests, those are the correct new values
SebastianMarian
previously approved these changes
Jan 16, 2021
iulianpascalau
dismissed stale reviews from SebastianMarian and sasurobert
via
ca1edbc
SebastianMarian
approved these changes
Jan 16, 2021
sasurobert
approved these changes
Jan 16, 2021
LucianMincu
approved these changes
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.