Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas refund to dev balance #2705

Merged
merged 15 commits into from Jan 16, 2021
Merged

Gas refund to dev balance #2705

merged 15 commits into from Jan 16, 2021

Conversation

sasurobert
Copy link
Contributor

@sasurobert sasurobert commented Jan 15, 2021

Gas refund to dev balance
Delete process if error which was called twice
Added statistics prints for load code process in account adapter implementations.

bogdan-rosianu
bogdan-rosianu previously approved these changes Jan 15, 2021
bogdan-rosianu
bogdan-rosianu previously approved these changes Jan 15, 2021
bogdan-rosianu
bogdan-rosianu previously approved these changes Jan 15, 2021
@@ -34,7 +69,8 @@ type AccountsDB struct {
entries []JournalEntry
mutOp sync.RWMutex

numCheckpoints uint32
numCheckpoints uint32
loadCodeMeasurements loadingMeasurements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loadCodeMeasurements *loadingMeasurements ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -70,6 +106,9 @@ func NewAccountsDB(
dataTries: NewDataTriesHolder(),
obsoleteDataTrieHashes: make(map[string][][]byte),
numCheckpoints: numCheckpoints,
loadCodeMeasurements: loadingMeasurements{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loadCodeMeasurements: &loadingMeasurements ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

bogdan-rosianu
bogdan-rosianu previously approved these changes Jan 15, 2021
bogdan-rosianu
bogdan-rosianu previously approved these changes Jan 15, 2021
bogdan-rosianu
bogdan-rosianu previously approved these changes Jan 16, 2021
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job!

@LucianMincu LucianMincu merged commit a1ba7f0 into development Jan 16, 2021
@LucianMincu LucianMincu deleted the gasRefund-to-devBalance branch January 16, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants