Liquid staking manager #3375
Liquid staking manager #3375
Conversation
# Conflicts: # vm/systemSmartContracts/esdt.go
| return returnCode | ||
| } | ||
| if len(args.Arguments) != 3 { | ||
| d.eei.AddReturnMessage("not enough arguments") |
There was a problem hiding this comment.
invalid number of arguments
|
|
||
| d.eei.Finish(totalRewards.Bytes()) | ||
| return vmcommon.UserError |
There was a problem hiding this comment.
return vmcommon.Ok
|
|
||
| func (d *delegation) unDelegateViaLiquidStaking(args *vmcommon.ContractCallInput) vmcommon.ReturnCode { | ||
| returnCode := d.returnViaLiquidStaking(args) | ||
| if returnCode != vmcommon.UserError { |
There was a problem hiding this comment.
if returnCode != vmcommon.Ok ?
| return returnCode | ||
| } | ||
| if len(args.Arguments) != 3 { | ||
| d.eei.AddReturnMessage("not enough arguments") |
There was a problem hiding this comment.
invalid number of arguments
| numOfCalls := big.NewInt(0).SetBytes(args.Arguments[0]).Int64() | ||
| minNumArguments := numOfCalls*2 + 1 | ||
| if int64(len(args.Arguments)) < minNumArguments { | ||
| l.eei.AddReturnMessage("invalid number of arguments") |
There was a problem hiding this comment.
"not enough arguments" ?
| return 0, err | ||
| } | ||
| if len(vmOutput.ReturnData) != 1 { | ||
| return 0, vm.ErrNotEnoughReturnData |
There was a problem hiding this comment.
len(vmOutput.ReturnData) < 1 or ErrInvalidReturnData ?
| } | ||
|
|
||
| return nil | ||
| } else { |
| destSCAddress []byte, | ||
| valueAsBytes []byte, | ||
| ) (uint64, *big.Int, vmcommon.ReturnCode) { | ||
| if len(destSCAddress) != len(l.liquidStakingSCAddress) || bytes.Equal(destSCAddress, l.liquidStakingSCAddress) { |
There was a problem hiding this comment.
can we have other "invalid addresses" like the validator/staking SC and such?
There was a problem hiding this comment.
it does not matter. as those system scs will error for the given input. would work with len check only.
| return vmOutput.ReturnData, vmcommon.Ok | ||
| } | ||
|
|
||
| func (l *liquidStaking) createOrAddNFT( |
There was a problem hiding this comment.
createOrAddSFT ? Valid for all these xxxNFTxxx functions.
| RewardsCheckpoint: rewardsCheckpoint, | ||
| } | ||
|
|
||
| marshalledData, err := l.marshalizer.Marshal(attributes) |
| } | ||
|
|
||
| func (l *liquidStaking) createNewNFT(value *big.Int) (uint64, error) { | ||
| valuePlusOne := big.NewInt(0).Add(value, big.NewInt(1)) |
There was a problem hiding this comment.
this a trick. You need to have at least 1 - in order to call AddQuantity - otherwise AddQuantity will fail. Thus we create one more and keep it in the contract.
| } | ||
| } | ||
|
|
||
| err := d.addValueToFund(delegator.ActiveFund, delegateValue) |
There was a problem hiding this comment.
...or return directly
Liquid staking manager contract