Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed termui remaining time metric #3434

Merged
merged 4 commits into from
Sep 13, 2021
Merged

Conversation

iulianpascalau
Copy link
Contributor

  • fixed termui remaining epoch time

@iulianpascalau iulianpascalau marked this pull request as draft September 13, 2021 13:36
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #3434 (1c45c0a) into development (77cc4af) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 1c45c0a differs from pull request most recent head bdc39eb. Consider uploading reports for the commit bdc39eb to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           development    #3434   +/-   ##
============================================
  Coverage        73.90%   73.90%           
============================================
  Files              578      578           
  Lines            73201    73201           
============================================
+ Hits             54096    54098    +2     
+ Misses           14739    14738    -1     
+ Partials          4366     4365    -1     
Impacted Files Coverage Δ
cmd/termui/presenter/chainInfoGetters.go 84.09% <0.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62c121d...bdc39eb. Read the comment docs.

@iulianpascalau iulianpascalau marked this pull request as ready for review September 13, 2021 14:11
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed

@gabi-vuls gabi-vuls merged commit dc806a1 into development Sep 13, 2021
@gabi-vuls gabi-vuls deleted the fix-termui-metrics branch September 13, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants