Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power in decentralization #3447

Merged
merged 5 commits into from Sep 21, 2021
Merged

Conversation

sasurobert
Copy link
Contributor

Power in decentralization

vm/systemSmartContracts/validator.go Show resolved Hide resolved
cmd/node/config/systemSmartContractsConfig.toml Outdated Show resolved Hide resolved
vm/systemSmartContracts/validator.go Outdated Show resolved Hide resolved
return nil, fmt.Errorf("%w in validatorSC", vm.ErrNilNodesCoordinator)
}
if args.StakingSCConfig.NodeLimitPercentage < minPercentage {
return nil, fmt.Errorf("%w in validatorSC", vm.ErrInvalidNodeLimitPercentage)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fmt.Errorf("%w in validatorSC for NodeLimitPercentage", vm.ErrInvalidNodeLimitPercentage)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. as you would duplicate the node limit percentage write

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, now I've saw ErrInvalidNodeLimitPercentage vs ErrInvalidStakeLimitPercentage

return nil, fmt.Errorf("%w in validatorSC", vm.ErrInvalidNodeLimitPercentage)
}
if args.StakingSCConfig.StakeLimitPercentage < minPercentage {
return nil, fmt.Errorf("%w in validatorSC", vm.ErrInvalidStakeLimitPercentage)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fmt.Errorf("%w in validatorSC for StakeLimitPercentage", vm.ErrInvalidNodeLimitPercentage)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. as you would duplicate the stake limit percentage write

nodesCoordinator: args.NodesCoordinator,
}

reg.totalStakeLimit = core.GetIntTrimmedPercentageOfValue(args.GenesisTotalSupply, args.StakingSCConfig.StakeLimitPercentage)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One idea spread in the office is to drop the stake limitation on the SP and only keep the node percentage limitation. In this way the "market" for the SPs will equalize itself while keeping the ability to absorb unstaked funds.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pretty much like "not getting involved" in office ideas.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After further discussions, can be left as it is in order to have some implemented control over the stake. The percentage can be later established.

@sasurobert sasurobert merged commit 15fa38e into feat/liquid-staking Sep 21, 2021
@sasurobert sasurobert deleted the power-in-decentralization branch September 21, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants