Internal block api unit testing #3695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdan-rosianu
requested changes
Jan 31, 2022
api/groups/internalGroup_test.go
Outdated
| expectedOutput := bytes.Repeat([]byte("1"), 10) | ||
|
|
||
| facade := mock.FacadeStub{ | ||
| GetInternalMetaBlockByHashCalled: func(_ common.OutportFormat, _ string) (interface{}, error) { |
There was a problem hiding this comment.
please rename OutportFormat to OutputFormat
node/blockAPI/internalBlock_test.go
Outdated
| storerMock := mock.NewStorerMock() | ||
| uint64Converter := mock.NewNonceHashConverterMock() | ||
|
|
||
| internalBlockProcessor := createMockInternalBlockProcessor( |
There was a problem hiding this comment.
might rename internalBlockProcessor to ibp as it has the same name as the struct
| @@ -154,7 +154,7 @@ func InitRatingsMetrics(statusHandlerUtils StatusHandlersUtils, ratingsConfig co | |||
| appStatusHandler.SetStringValue(common.MetricRatingsMetaChainConsecutiveMissedBlocksPenalty, fmt.Sprintf("%f", ratingsConfig.MetaChain.ConsecutiveMissedBlocksPenalty)) | |||
|
|
|||
| appStatusHandler.SetStringValue(common.MetricRatingsPeerHonestyDecayCoefficient, fmt.Sprintf("%f", ratingsConfig.PeerHonesty.DecayCoefficient)) | |||
| appStatusHandler.SetUInt64Value(common.MetricRatingsPeerHonestyDecayCoefficient, uint64(ratingsConfig.PeerHonesty.DecayUpdateIntervalInSeconds)) | |||
| appStatusHandler.SetUInt64Value(common.MetricRatingsPeerHonestyDecayUpdateIntervalInSeconds, uint64(ratingsConfig.PeerHonesty.DecayUpdateIntervalInSeconds)) | |||
node/node.go
Outdated
| @@ -1404,7 +1404,8 @@ func (n *Node) getKeyBytes(key string) ([]byte, error) { | |||
| return hex.DecodeString(key) | |||
| } | |||
|
|
|||
| func (n *Node) createInternalBlockProcessor() error { | |||
| // CreateInternalBlockProcessor creates the block processor for handling internal block header | |||
| func (n *Node) CreateInternalBlockProcessor() error { | |||
There was a problem hiding this comment.
why did you export it? if only for testing, then you'd better create an export_test.go file where you export this function ONLY for testing purposes
There was a problem hiding this comment.
right, exported function in export_test.go
node/nodeInternalBlocks_test.go
Outdated
| err := n.CreateInternalBlockProcessor() | ||
| require.Nil(t, err) | ||
|
|
||
| blk, err := n.GetInternalShardBlockByHash(common.Internal, "wronghashformat") |
There was a problem hiding this comment.
might rename Internal from common to ApiOutputFormatInternal
also rename Proto from internal to ApiOutputFormatProto
also rename OutportFormat to ApiOutputFormat
| @@ -255,7 +255,7 @@ func (sm *statusMetrics) RatingsMetrics() map[string]interface{} { | |||
| ratingsMetrics[common.MetricRatingsGeneralSignedBlocksThreshold] = sm.loadStringMetric(common.MetricRatingsGeneralSignedBlocksThreshold) | |||
|
|
|||
| numSelectionChances := sm.loadUint64Metric(common.MetricRatingsGeneralSelectionChances + "_count") | |||
| selectionChances := make([]interface{}, 0) | |||
| selectionChances := make([]map[string]interface{}, 0) | |||
There was a problem hiding this comment.
the items within the map seem only to be uint64. therefore, we could change the map from map[string]interface{} to map[string]uint64
bogdan-rosianu
requested changes
Jan 31, 2022
|
|
||
| for i, selectionChance := range selectionChances { | ||
| maxThresholdStr := fmt.Sprintf("%s%d%s", common.MetricRatingsGeneralSelectionChances, i, common.SelectionChancesMaxThresholdSuffix) | ||
| sm.SetUInt64Value(maxThresholdStr, uint64(selectionChance["MaxThreshold"])) |
There was a problem hiding this comment.
Redundant type conversion
| maxThresholdStr := fmt.Sprintf("%s%d%s", common.MetricRatingsGeneralSelectionChances, i, common.SelectionChancesMaxThresholdSuffix) | ||
| sm.SetUInt64Value(maxThresholdStr, uint64(selectionChance["MaxThreshold"])) | ||
| chancePercentStr := fmt.Sprintf("%s%d%s", common.MetricRatingsGeneralSelectionChances, i, common.SelectionChancesChancePercentSuffix) | ||
| sm.SetUInt64Value(chancePercentStr, uint64(selectionChance["ChancePercent"])) |
There was a problem hiding this comment.
Redundant type conversion
- renaming - use valid hash in tests - rename OutportFormat type and vars - status handler - ratings metrics improvements
…twork/elrond-go into internal-block-api-unit-testing
ssd04
force-pushed
the
internal-block-api-unit-testing
branch
from
3bd095f
to
3938e57
Compare
bogdan-rosianu
previously approved these changes
Feb 2, 2022
AdoAdoAdo
requested changes
Feb 4, 2022
- handler errors properly - improve coverage
AdoAdoAdo
previously approved these changes
Feb 4, 2022
- remove duplicate error - handler error cases properly - reduce duplicate code
AdoAdoAdo
requested changes
Feb 4, 2022
AdoAdoAdo
approved these changes
Feb 4, 2022
bogdan-rosianu
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit testing on several parts regarding internal block headers exposure: