Peer authentication sender #3771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
Feb 8, 2022
iulianpascalau
commented
- added peer authentication sender
- added routineHandler & timerWrapper sub-components
- renamed some interfaces, stub implementations and errors
- added routineHandler & timerWrapper sub-components - renamed some interfaces, stub implementations and errors
| pkBytes, _ := sender.publicKey.ToByteArray() | ||
| log.Info("args", "pid", args.Messenger.ID().Pretty(), "bls sk", skBytes, "bls pk", pkBytes) | ||
|
|
||
| // verify the received bytes if they can be converted in a valid peer authentication message |
There was a problem hiding this comment.
you can transform these comments into t.Run("description")
There was a problem hiding this comment.
can be done, sure
dragos-rebegea
previously approved these changes
Feb 9, 2022
sstanculeanu
previously approved these changes
Feb 10, 2022
|
|
||
| const minTimeBetweenSends = time.Second | ||
|
|
||
| // ArgPeerAuthenticationSender represents the arguments for the heartbeat sender |
There was a problem hiding this comment.
Suggested change
| // ArgPeerAuthenticationSender represents the arguments for the heartbeat sender | |
| // ArgPeerAuthenticationSender represents the arguments for the peer authentication sender |
sstanculeanu
approved these changes
Feb 11, 2022
dragos-rebegea
approved these changes
Feb 11, 2022
iulianpascalau
added
type:feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.