Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/header verification #3812

Merged
merged 124 commits into from
Mar 14, 2022
Merged

Feat/header verification #3812

merged 124 commits into from
Mar 14, 2022

Conversation

ssd04
Copy link
Contributor

@ssd04 ssd04 commented Feb 17, 2022 •
edited

Refactor sharding package:

  • move nodesCoordinator to a separate package inside sharding directory

Extend node api with /internal route in order to be able to fetch raw marshalized data for headers and miniblocks:

  • separate route for shardblock and metablock
  • each case has 3 different options: by-hash, by-nonce, by-round

Update /network route:

  • added /ratings endpoint
  • updated /config endpoint

@ssd04
added new routes for raw block proto
fd5346e
@ssd04
expose block as byte array instead of protoBuf
3150256
@ssd04
renamed GetRawBlock to refer to meta block specifically
4599187
@ssd04
added routes for shard block
c5d620b
@ssd04
export miniblocks as raw data
297cf82
@ssd04
added asJson flag to specify raw or json data format
a371f64
@ssd04
export metrics for ratings config
f40305c
@ssd04
renamed raw group to internal
97283b2
@ssd04
create separate routes for json and raw format instead of having a fl…
88efaf5 
…ag parameter
@ssd04
added separate rawBlockProcessor
1a5c5af
@ssd04
remove json flag entirely + renamed Json to Internal
fdb4266
@ssd04
error handling for shard specific endpoints
2650523
@ssd04
json route for miniblocks
af375aa
@ssd04
fix ratings config selectionChances setup
30f1d97
@ssd04
cleanup and comments update
eff79cd
@ssd04
refactor: removed GetRawBlock functions, added outport format flag
b1e01cc
@ssd04
renamed raw files to internal
edc8872
@ssd04
refactoring get raw miniblock functions
d2cab5e
@ssd04
fix ratings config metrics generation
6e0d12d
@ssd04
renaming and comments update
1af9319
@ssd04
fix mocks
e23a064
@ssd04
refactor createInternalBlockProcessor instantiation
839c57d
@ssd04
renamed all raw referencies to internal
5873d2c
@ssd04
metrics stub rename update
6a39ac1
@ssd04
unit test for status handler metrics
fad08a1
@ssd04
more renaming update
48ea827
@ssd04
fix api already implemented unit tests
3ac32e1
@ssd04
Merge branch 'export-internal-block-to-api' into internal-block-api-u…
0315933 
…nit-testing
@ssd04
test cleanup + small refactorings
4944ee5
@ssd04
Merge branch 'export-internal-block-to-api' into internal-block-api-u…
bb15e67 
…nit-testing
ssd04 added 15 commits March 4, 2022 15:41
@ssd04
change node api config
130f6a2
@ssd04
moved genesis nodes endpoint to network group
f39ebb0
@ssd04
unit test getGenesisNodes in node api resolver
3fd4f7b
@ssd04
fix api resolver stub
03a60ee
@ssd04
update facade interface in integration tests
3c9c9ab
@ssd04
fix nil api resolver
c4b31f6
@ssd04
fixes after review: comment name and nil check in facade
df72190
@ssd04
GetGenesisNodes - update unit test
9e2c52d
@ssd04
fix after review: remove unnecessary header cast
e2c19c7
@ssd04
update facade in integration tests
64a6b36
@ssd04
refactor to export pubkey encoded using validatorPubKeyConverter
c648dba
@ssd04
fixes after review: small changes
afb31ca
@ssd04
Merge pull request #3875 from ElrondNetwork/handle-epoch-zero
6c3c5dd 
Handle epoch zero
@ssd04
rename network/genesisnodes to network/genesis-nodes
4d9ed6d
@ssd04
Merge pull request #3888 from ElrondNetwork/update-genesis-nodes-endp…
124aac3 
…oint

Rename network/genesisnodes to network/genesis-nodes
gabi-vuls
gabi-vuls previously approved these changes Mar 9, 2022
View reviewed changes
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.

bogdan-rosianu
bogdan-rosianu previously approved these changes Mar 11, 2022
View reviewed changes
@AdoAdoAdo
Merge pull request #3897 from ElrondNetwork/merge-dev-into-header-ver…
0ffa0fa 
…ification-11-03-2022

Merge dev into header verification 11 03 2022
@AdoAdoAdo AdoAdoAdo dismissed stale reviews from bogdan-rosianu and gabi-vuls via 0ffa0fa March 11, 2022 11:32
gabi-vuls
gabi-vuls approved these changes Mar 14, 2022
View reviewed changes
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed

@iulianpascalau iulianpascalau self-requested a review March 14, 2022 15:51
@iulianpascalau iulianpascalau merged commit a983cb3 into development Mar 14, 2022
@iulianpascalau iulianpascalau deleted the feat/header-verification branch March 14, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iulianpascalau iulianpascalau iulianpascalau approved these changes

@gabi-vuls gabi-vuls gabi-vuls approved these changes

@bogdan-rosianu bogdan-rosianu bogdan-rosianu approved these changes

Assignees

@ssd04 ssd04

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ssd04 @iulianpascalau @gabi-vuls @bogdan-rosianu @AdoAdoAdo