Staking v4 init auciton nodes list #3818
Conversation
epochStart/metachain/systemSCs.go
Outdated
| @@ -313,6 +317,13 @@ func (s *systemSCProcessor) ProcessSystemSmartContract( | |||
| } | |||
| } | |||
|
|
|||
| if s.flagStakingV4Enabled.IsSet() { | |||
There was a problem hiding this comment.
287 you need a disable flag
There was a problem hiding this comment.
- Renamed to
flagStakingV4InitEnabled - Also added a disable flag
mariusmihaic
changed the title
cmd/node/config/enableEpochs.toml
Outdated
| @@ -187,6 +187,10 @@ | |||
| # StakeLimitsEnableEpoch represents the epoch when stake limits on validators are enabled | |||
| StakeLimitsEnableEpoch = 5 | |||
|
|
|||
| # StakingV4InitEnableEpoch represents the epoch when staking v4 is initialized. This is the epoch in which | |||
| # all nodes from staking queue are moved in the auction list | |||
| StakingV4InitEnableEpoch = 1000000 | |||
There was a problem hiding this comment.
for testing purposes you can set this to 3 or 4
There was a problem hiding this comment.
Right, changed it
| @@ -313,6 +320,13 @@ func (s *systemSCProcessor) ProcessSystemSmartContract( | |||
| } | |||
| } | |||
|
|
|||
| if s.flagInitStakingV4Enabled.IsSet() { | |||
There was a problem hiding this comment.
this will be called only on the epoch when we activate the staking v4. Is this correct?
Do we need this flag to execute something only on the activation epoch?
There was a problem hiding this comment.
Yes. This is the expected behavior. We only want these actions to happen only once, hence the name StakingV4InitEnableEpoch.
On this epoch, the only thing we want is to move all nodes from staking queue to auction list ("remove" waiting list).
Starting next epoch, using another flag -StakingV4EnableEpoch- we will start sorting auction nodes based on top up.
Reason being that we only want to "empty" the staking queue only once
Auction list