Cleanup: moved the blockchain instantiation from the vm container factory #3825
Conversation
iulianpascalau
commented
Feb 21, 2022
•
iulianpascalau
commented
- moved the blockchain hook instantiation from the vm container factory
- switched the usage of the accounts adapter API on the api-related operations
Codecov Report
@@ Coverage Diff @@
## development #3825 +/- ##
===============================================
- Coverage 74.62% 74.61% -0.01%
===============================================
Files 606 606
Lines 79672 79694 +22
===============================================
+ Hits 59457 59467 +10
- Misses 15640 15648 +8
- Partials 4575 4579 +4
Continue to review full report at Codecov.
|
| @@ -59,6 +58,8 @@ type ArgsNewVMContainerFactory struct { | |||
| EpochNotifier process.EpochNotifier | |||
| EpochConfig *config.EpochConfig | |||
| ShardCoordinator sharding.Coordinator | |||
| PubkeyConv core.PubkeyConverter | |||
| BlockChainHook process.BlockChainHookHandler | |||
| @@ -230,8 +230,6 @@ func (m *Monitor) loadHeartbeatsFromStorer(pubKey string) (*heartbeatMessageInfo | |||
| receivedHbmi := m.convertFromExportedStruct(*heartbeatDTO, m.maxDurationPeerUnresponsive) | |||
| receivedHbmi.getTimeHandler = m.timer.Now | |||
| crtTime := m.timer.Now() | |||
| crtDuration := crtTime.Sub(receivedHbmi.lastUptimeDowntime) | |||
| crtDuration = maxDuration(0, crtDuration) | |||
There was a problem hiding this comment.
Unused variable not spotted by the compiler? :)
There was a problem hiding this comment.
spotted by the linter, actually. :)
testscommon/blockChainHookStub.go
Outdated
| // IsPayable - | ||
| func (stub *BlockChainHookStub) IsPayable(_ []byte, recvAddress []byte) (bool, error) { | ||
| if stub.IsPayableCalled != nil { | ||
| return stub.IsPayableCalled(recvAddress) |
There was a problem hiding this comment.
don't ignore the first param as we might have some tests where we'd like to check it
| argsNewVmFactory := metachain.ArgsNewVMContainerFactory{ | ||
| ArgBlockChainHook: argsHook, | ||
| BlockChainHook: blockChainHookImpl, |
There was a problem hiding this comment.
CreateApiResolver uses AccountsAdapter and not AccountsAdapterAPI. expected?
There was a problem hiding this comment.
switched the usage of the AccountsAdapterApi but kept the read only accounts adapter wrapper in order to keep the consistency when executing (readonly accounts adapter won't call SaveAccount, for example, but won't return an error as the AccountsAdapterApi would)
