Fetch start of epoch metablock #3856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -153,6 +153,23 @@ func (ibp *internalBlockProcessor) GetInternalMetaBlockByRound(format common.Api | |||
| return ibp.convertMetaBlockBytesByOutputFormat(format, blockBytes) | |||
| } | |||
|
|
|||
| // GetInternalStartOfEpochMetaBlock wil return a meta block by hash | |||
There was a problem hiding this comment.
// GetInternalStartOfEpochMetaBlock wil return the epoch start meta block for the provided epoch
There was a problem hiding this comment.
also, can you add unit tests for this function ?
node/external/nodeApiResolver.go
Outdated
| @@ -161,6 +161,12 @@ func (nar *nodeApiResolver) GetInternalMetaBlockByRound(format common.ApiOutputF | |||
| return nar.apiInternalBlockHandler.GetInternalMetaBlockByRound(format, round) | |||
| } | |||
|
|
|||
| // GetInternalStartOfEpochMetaBlock wil return start of epoch meta block | |||
There was a problem hiding this comment.
// GetInternalStartOfEpochMetaBlock will return the start of epoch meta block for the provided epoch
iulianpascalau
previously approved these changes
Mar 1, 2022
| } | ||
|
|
||
| start := time.Now() | ||
| block, err := ib.getFacade().GetInternalStartOfEpochMetaBlock(common.ApiOutputFormatInternal, epoch) |
There was a problem hiding this comment.
so we have
common.ApiOutputFormatInternal
common.ApiOutputFormatProtoCan we rename ApiOutputFormatInternal to something else? It took me several minutes to figure out which is returning what. InternalMarshalizer is the GogoProtoMarshalizer. I thought they were the same.
Can be done in a separate PR
There was a problem hiding this comment.
will do in a separate PR 👍
iulianpascalau
approved these changes
Mar 1, 2022
bogdan-rosianu
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement separate endpoint for fetching start of epoch metablock by specifying the epoch.