Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close network components first #3863

Merged
merged 3 commits into from
Mar 4, 2022
Merged

Conversation

ssd04
Copy link
Contributor

@ssd04 ssd04 commented Mar 2, 2022

Changed closable components order on close: set network components to be closed at first, so that network traffic will not be initiated while data and state components are still active.

Added nil checks for status handler goroutine which will try to fetch network components metric:

  • nil check for network messenger component

@ssd04 ssd04 self-assigned this Mar 2, 2022
AdoAdoAdo
AdoAdoAdo previously approved these changes Mar 2, 2022
iulianpascalau
iulianpascalau previously approved these changes Mar 2, 2022
bogdan-rosianu
bogdan-rosianu previously approved these changes Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #3863 (340b5a4) into development (c4e6063) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3863      +/-   ##
===============================================
- Coverage        74.83%   74.82%   -0.01%     
===============================================
  Files              611      611              
  Lines            80805    80810       +5     
===============================================
  Hits             60468    60468              
- Misses           15701    15706       +5     
  Partials          4636     4636              
Impacted Files Coverage Δ
factory/statusComponentsHandler.go 16.45% <0.00%> (-0.36%) ⬇️
node/nodeHelper.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b13c96...340b5a4. Read the comment docs.

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.

@gabi-vuls gabi-vuls merged commit 88c0527 into development Mar 4, 2022
@gabi-vuls gabi-vuls deleted the close-network-components-first branch March 4, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants