Send data on connected peer #3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
Mar 10, 2022
iulianpascalau
commented
- added the possibility to send to a newly connected peer some extra data
iulianpascalau
commented
Mar 11, 2022
install-proto.sh
Outdated
| @@ -42,7 +42,7 @@ cd "${GOPATH}"/src/github.com/ElrondNetwork | |||
| if [ ! -d "protobuf" ] | |||
| then | |||
| echo "Cloning ElrondNetwork/protobuf..." | |||
| git clone https://github.com/ElrondNetwork/protobuf.git | |||
| git clone https://github.com/ElrondNetwork/protobuf/protobuf.git | |||
|
|
||
| netMes.mutCurrentBytesProvider.Lock() | ||
| netMes.currentBytesProvider = currentBytesProvider | ||
| netMes.mutCurrentBytesProvider.Unlock() |
There was a problem hiding this comment.
after setting the new currentBytesProvider let's notify all already connected peers. In this way, all other peers will be notified what is the new shard for the connected peer
| @@ -493,6 +500,22 @@ func (netMes *networkMessenger) createConnectionMonitor(p2pConfig config.P2PConf | |||
| return nil | |||
| } | |||
|
|
|||
| // PeerConnected can be called whenever a new peer is connected to this host | |||
| func (netMes *networkMessenger) PeerConnected(pid core.PeerID) { | |||
There was a problem hiding this comment.
we should think of a way to somehow close the network messenger after the bootstrapping is done.
Why? Because we should correctly setup the network messenger with the "final" processing components able to be notified and notify as well the new peers that will interact with. Will think of a solution to this.
sstanculeanu
previously approved these changes
Mar 11, 2022
sstanculeanu
previously approved these changes
Mar 14, 2022
bogdan-rosianu
approved these changes
Mar 14, 2022
sstanculeanu
approved these changes
Mar 14, 2022
iulianpascalau
added
type:feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.