integrate new vm parameters #3913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #3913 +/- ##
============================================
Coverage 74.84% 74.84%
============================================
Files 614 614
Lines 81721 81723 +2
============================================
+ Hits 61162 61164 +2
Misses 15899 15899
Partials 4660 4660
Continue to review full report at Codecov.
|
camilbancioiu
previously approved these changes
Mar 17, 2022
cmd/node/config/config.toml
Outdated
| @@ -696,13 +696,17 @@ | |||
|
|
|||
| [VirtualMachine] | |||
| [VirtualMachine.Execution] | |||
| TimeOutForSCExecutionInMilliseconds = 10000 # 10 seconds = 10000 milliseconds | |||
| WasmerSIGSEGVPassthrough = false | |||
There was a problem hiding this comment.
Since this is a very sensitive config, I would simply use a const for this.
The const would have been altered when the system test prepared by a sed command.
go.mod
Outdated
| @@ -57,6 +57,6 @@ replace github.com/ElrondNetwork/arwen-wasm-vm/v1_2 v1.2.39 => github.com/Elrond | |||
|
|
|||
| replace github.com/ElrondNetwork/arwen-wasm-vm/v1_3 v1.3.39 => github.com/ElrondNetwork/arwen-wasm-vm v1.3.39 | |||
|
|
|||
| replace github.com/ElrondNetwork/arwen-wasm-vm/v1_4 v1.4.44 => github.com/ElrondNetwork/arwen-wasm-vm v1.4.44 | |||
| replace github.com/ElrondNetwork/arwen-wasm-vm/v1_4 v1.4.44 => github.com/ElrondNetwork/arwen-wasm-vm v1.4.45-0.20220317104253-9919c14d121e | |||
camilbancioiu
approved these changes
Mar 18, 2022
iulianpascalau
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integrate new vm parameters