Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk request size parameter elastic indexer #3925

Merged
merged 5 commits into from Mar 24, 2022

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Mar 21, 2022

  • Added an extra parameter in the external.toml config file in order to can configure the maximum size of an indexer bulk request.
  • We need this parameter in order to can increase the indexing speed ( instead of doing multiple small bulk requests we will do fewer requests but bigger.

Password = ""
Enabled = false
IndexerCacheSize = 0
BulkRequestMaxSize = 4000000 # 4MB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rename it to BulkRequestMaxSizeInBytes ? also, 4 mb is 4194304 bytes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@miiu96 miiu96 merged commit 96affbd into master-with-indexer-v1-2-x Mar 24, 2022
@miiu96 miiu96 deleted the bulk-request-size-parameter branch March 24, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants