Add ConnectionTopic in order to feed the peers shard mapper with the info that HeartbeatV2 does not have #3927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved the logic for currentPayloadProvider
sstanculeanu
changed the title
removed assert on unknown peers
fixed data races
heartbeat/processor/peerAuthenticationRequestsProcessor_test.go
Outdated
Show resolved
Hide resolved
process/factory/interceptorscontainer/baseInterceptorsContainerFactory.go
Outdated
Show resolved
Hide resolved
| @@ -690,27 +690,27 @@ func (bicf *baseInterceptorsContainerFactory) generateHeartbeatInterceptor() err | |||
|
|
|||
| // ------- ShardValidatorInfo interceptor | |||
| @@ -118,7 +118,7 @@ func Test_shardValidatorInfoInterceptorProcessor_Save(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func Test_shardValidatorInfoInterceptorProcessor_DisabledMethods(t *testing.T) { | |||
| func Test_validatorInfoInterceptorProcessor_DisabledMethods(t *testing.T) { | |||
There was a problem hiding this comment.
TestValidatorInfoInterceptorProcessor_DisabledMethod ?
This suggestion will comply with the rest of the project's naming conventions
| assert.Nil(t, err) | ||
| assert.False(t, check.IfNil(processor)) | ||
| }) | ||
| } | ||
|
|
||
| func Test_shardValidatorInfoInterceptorProcessor_Save(t *testing.T) { | ||
| func Test_validatorInfoInterceptorProcessor_Save(t *testing.T) { |
There was a problem hiding this comment.
TestValidatorInfoInterceptorProcessor_Save ?
ssd04
reviewed
Mar 24, 2022
process/interceptors/processor/shardValidatorInfoInterceptorProcessor.go
Outdated
Show resolved
Hide resolved
ssd04
approved these changes
Mar 24, 2022
iulianpascalau
approved these changes
Mar 24, 2022
sstanculeanu
changed the title
iulianpascalau
added
type:feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
directConnectionsProcessorwhich sends a message with shard id to all connected peers on a separate goroutine. Added this component as aheartbeatV2Component.ConnectionTopicused by the above component, which saves the pair pid-shard id into peer shard mapper.crossShardStatusProcessoras it is not used anymore.currentPayloadProvider.