Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate validators info map into rewards creator #3929

Merged
merged 4 commits into from Mar 24, 2022
Merged

Integrate validators info map into rewards creator #3929

merged 4 commits into from Mar 24, 2022

Conversation

mariusmihaic
Copy link
Contributor

@mariusmihaic mariusmihaic commented Mar 22, 2022 •
edited

  • Replaced map[uin32][]*ValidatorInfo with ShardValidatorsInfoMap interface in rewardsCreator
  • Deleted duplicated stubs and kept only one in testscommon

@mariusmihaic mariusmihaic self-assigned this Mar 22, 2022
@mariusmihaic mariusmihaic marked this pull request as ready for review March 22, 2022 13:31
@bogdan-rosianu bogdan-rosianu self-requested a review March 22, 2022 14:18
Base automatically changed from validators-info-into-validator-creator to feat/liquid-staking March 24, 2022 11:40
@mariusmihaic mariusmihaic merged commit cd72944 into feat/liquid-staking Mar 24, 2022
@mariusmihaic mariusmihaic deleted the validators-info-into-rewards-creator branch March 24, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasurobert sasurobert sasurobert approved these changes

@bogdan-rosianu bogdan-rosianu bogdan-rosianu approved these changes

Assignees

@mariusmihaic mariusmihaic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mariusmihaic @sasurobert @bogdan-rosianu