Log life spanner for file size #3940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
Mar 25, 2022
iulianpascalau
commented
- implemented log life spanner for file size
AdoAdoAdo
approved these changes
Mar 28, 2022
| oneMegaByte = 1024 * 1024 | ||
| minFileLifeSpan = time.Second | ||
| minSizeInMB = uint64(1) | ||
| maxSizeInMB = uint64(1024 * 1024) // 1TB |
There was a problem hiding this comment.
does it make sense to hold such a large value?
even if we hold it, it will be difficult to open it and analyze.
There was a problem hiding this comment.
it was just a maximum allowed value. What value should I put there?
bogdan-rosianu
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.