fix-transferRole-check-on-esdtTransfer #4014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## rc/2022-may #4014 +/- ##
===============================================
- Coverage 74.79% 74.78% -0.01%
===============================================
Files 609 609
Lines 80935 80944 +9
===============================================
Hits 60536 60536
- Misses 15764 15771 +7
- Partials 4635 4637 +2
Continue to review full report at Codecov.
|
andrei-marinica
previously approved these changes
Apr 22, 2022
dragos-rebegea
previously approved these changes
Apr 22, 2022
| ESDTTransferRoleEnableEpoch: enableEpochs.ESDTTransferRoleEnableEpoch, | ||
| GlobalMintBurnDisableEpoch: enableEpochs.GlobalMintBurnDisableEpoch, | ||
| ESDTTransferMetaEnableEpoch: enableEpochs.BuiltInFunctionOnMetaEnableEpoch, | ||
| OptimizeNFTStoreEnableEpoch: enableEpochs.OptimizeNFTStoreEnableEpoch, |
There was a problem hiding this comment.
this was a forgotten flag. Does the code is still backwards compatible now?
There was a problem hiding this comment.
having a second thought, let's keep it this way as this is the correct way. Will deal with the import-db process afterwards
go.mod
Outdated
| @@ -12,7 +12,7 @@ require ( | |||
| github.com/ElrondNetwork/elrond-go-core v1.1.15 | |||
| github.com/ElrondNetwork/elrond-go-crypto v1.0.1 | |||
| github.com/ElrondNetwork/elrond-go-logger v1.0.5 | |||
| github.com/ElrondNetwork/elrond-vm-common v1.2.12 | |||
| github.com/ElrondNetwork/elrond-vm-common v1.2.14-0.20220421185714-edf68ab67a9e | |||
sasurobert
dismissed stale reviews from dragos-rebegea and andrei-marinica
via
123951d
popenta
previously approved these changes
Apr 22, 2022
There was a problem hiding this comment.
@@ Log scanner @@
fix-transferRole-check-on-transfer
================================================================================
- Known Warnings 450
- New Warnings 342
- Known Errors 0
- New Errors 0
- Panics 0
================================================================================
iulianpascalau
requested changes
Apr 23, 2022
iulianpascalau
changed the base branch from
feat/release-2022-April
to
rc/2022-may
iulianpascalau
approved these changes
Apr 23, 2022
andrei-marinica
approved these changes
Apr 23, 2022
LucianMincu
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integrated new flag