Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed epoch start metrics #4039

Merged
merged 4 commits into from
May 3, 2022
Merged

Conversation

bogdan-rosianu
Copy link
Contributor

fixed round at epoch start and nonce at epoch start metrics.

@bogdan-rosianu bogdan-rosianu self-assigned this Apr 29, 2022
@ssd04 ssd04 self-requested a review April 29, 2022 11:52
dragos-rebegea
dragos-rebegea previously approved these changes Apr 29, 2022
sstanculeanu
sstanculeanu previously approved these changes Apr 29, 2022
ssd04
ssd04 previously approved these changes Apr 29, 2022
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #4039 (bee78b5) into development (1b88d03) will not change coverage.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##           development    #4039   +/-   ##
============================================
  Coverage        75.24%   75.24%           
============================================
  Files              614      614           
  Lines            82088    82088           
============================================
  Hits             61769    61769           
  Misses           15641    15641           
  Partials          4678     4678           
Impacted Files Coverage Δ
epochStart/bootstrap/process.go 84.39% <ø> (-0.05%) ⬇️
node/metrics/metrics.go 64.64% <ø> (-0.39%) ⬇️
statusHandler/persister/persistentHandler.go 81.73% <0.00%> (-1.61%) ⬇️
process/sync/loadPersistentMetrics.go 94.33% <100.00%> (+0.22%) ⬆️
storage/txcache/txListBySenderMap.go 100.00% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6662d85...bee78b5. Read the comment docs.

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.
Known warnings are present before de upgrade to this branch.

@@ Log scanner @@

epoch-start-metrics-fixes

================================================================================

  • Known Warnings 25
  • New Warnings 7
  • Known Errors 1
  • New Errors 0
  • Panics 0
    ================================================================================

@bogdan-rosianu bogdan-rosianu merged commit f8e2413 into development May 3, 2022
@bogdan-rosianu bogdan-rosianu deleted the epoch-start-metrics-fixes branch May 3, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants