Staking v4 - Integration tests with custom scenarios #4045
Conversation
mariusmihaic
changed the title
…959-staking-v4-integration-tests-custom-scenarios
…ation-tests-custom-scenarios
mariusmihaic
changed the base branch from
EN-11957-move-unjailed-new-nodes-to-auction
to
fix-waiting-list-tests
Codecov Report
@@ Coverage Diff @@
## feat/liquid-staking #4045 +/- ##
=======================================================
- Coverage 75.38% 75.38% -0.01%
=======================================================
Files 622 622
Lines 83275 83275
=======================================================
- Hits 62779 62778 -1
- Misses 15773 15774 +1
Partials 4723 4723
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## feat/liquid-staking #4045 +/- ##
=======================================================
- Coverage 75.38% 75.38% -0.01%
=======================================================
Files 622 622
Lines 83275 83275
=======================================================
- Hits 62779 62777 -2
- Misses 15773 15774 +1
- Partials 4723 4724 +1
Continue to review full report at Codecov.
|
…on-tests-custom-scenarios
| ) *TestMetaProcessor { | ||
| gasScheduleNotifier := createGasScheduleNotifier() | ||
| blockChainHook := createBlockChainHook( | ||
| dataComponents, coreComponents, |
There was a problem hiding this comment.
coreComponents on new line?
There was a problem hiding this comment.
Right, missed it;
Added new line
| @@ -65,7 +73,37 @@ func requireMapDoesNotContain(t *testing.T, m map[uint32][][]byte, s [][]byte) { | |||
| } | |||
| } | |||
|
|
|||
| // TODO: Staking v4: more tests to check exactly which nodes have been selected/unselected from previous nodes config auction | |||
| func remove(s [][]byte, elem []byte) [][]byte { | |||
There was a problem hiding this comment.
please rename and use better names for variables. a better name would be removeItemFromSliceWithoutKeepingOrder
There was a problem hiding this comment.
I think this name is a bit too lengthy and maybe not worth describing its behavior for a test. Added a comm to highlight its behavior. Also, renamed s -> slice
| @@ -320,7 +320,7 @@ func calcNormRand(randomness []byte, expectedLen int) []byte { | |||
| randLen := len(rand) | |||
|
|
|||
| if expectedLen > randLen { | |||
| repeatedCt := expectedLen/randLen + 1 | |||
| repeatedCt := expectedLen/randLen + 1 // todo: fix possible div by 0 | |||
There was a problem hiding this comment.
Left a //todo there so I can fix it in the next PR in which I will create a separate component for auction selection.
This is going to be fixed in the next PR, along with the new subcomp, so we don't "clutter" this PR with anymore changes.
mariusmihaic
deleted the
EN-11959-staking-v4-integration-tests-custom-scenarios
branch
Bug fixes
AddValidatorDataRefactor
GetAllNodeKeysfromsystemSCs.goto a new file to be used in tests as wellProcessSCOutputAccountsfromTestNodeProcessorto be used in staking v4 testsbaseTestMetaProcessor.gowhich handles creation of aTestMetaProcessorregardless ofNewTestMetaProcessor/NewTestMetaProcessorWithCustomNodes. Most of the functionality in this file is taken fromtestMetaProcessor.goNew tests
StakingToPeerto handle staking new nodes after staking v4 epoch, which should save new peer accounts in auctionTestStakingV4_UnStakeNodesWithNotEnoughFundswhich tests how nodes are unstaked at the end of the epoch in case they don't have enough funds. Before staking v4(including staking v4 init epoch), nodes should be unstaked based on prority: queue -> waiting -> eligible. After staking v4, priority should be auction -> waiting -> eligibleTestStakingV4_StakeNewNodestests functionality of staking new nodes after staking v4(they should be sent to auction)