Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding keys to waiting list in tests setup #4049

Merged
merged 5 commits into from May 4, 2022

Conversation

mariusmihaic
Copy link
Contributor

@mariusmihaic mariusmihaic commented May 3, 2022

  • There were some bugs in two testing helper functions which worked with staking queue: SaveOneKeyToWaitingList &AddKeysToWaitingList. If no key were already saved in waiting list, AddKeysToWaitingList would have failed.
  • Removed SaveOneKeyToWaitingList
  • Refactored AddKeysToWaitingList to work by adding one/multiple keys after multiple calls
  • Moved getWaitingListElement from staking v4 integration tests into stakingCommon.go

@mariusmihaic mariusmihaic self-assigned this May 3, 2022
Base automatically changed from EN-11957-move-unjailed-new-nodes-to-auction to feat/liquid-staking May 3, 2022 15:05
@mariusmihaic mariusmihaic marked this pull request as ready for review May 4, 2022 06:51
@mariusmihaic mariusmihaic changed the title FIX: AddKeysToWaitingList in tests Fix adding keys to waiting list in tests setup May 4, 2022
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #4049 (363865a) into feat/liquid-staking (1464814) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 363865a differs from pull request most recent head a3bbea0. Consider uploading reports for the commit a3bbea0 to get more accurate results

@@                   Coverage Diff                   @@
##           feat/liquid-staking    #4049      +/-   ##
=======================================================
- Coverage                75.38%   75.38%   -0.01%     
=======================================================
  Files                      622      622              
  Lines                    83275    83275              
=======================================================
- Hits                     62779    62774       -5     
- Misses                   15773    15776       +3     
- Partials                  4723     4725       +2     
Impacted Files Coverage Δ
storage/txcache/txListBySenderMap.go 97.50% <0.00%> (-2.50%) ⬇️
p2p/libp2p/netMessenger.go 74.56% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97275d1...a3bbea0. Read the comment docs.

@ssd04 ssd04 self-requested a review May 4, 2022 12:03
@mariusmihaic mariusmihaic merged commit 29a59c4 into feat/liquid-staking May 4, 2022
@mariusmihaic mariusmihaic deleted the fix-waiting-list-tests branch May 4, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants