Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatted code with gofmt #4065

Merged
merged 2 commits into from
May 10, 2022
Merged

Formatted code with gofmt #4065

merged 2 commits into from
May 10, 2022

Conversation

bogdan-rosianu
Copy link
Contributor

run go fmt ./... on the project root in order to fix all misaligned items, unsorted imports, more/fewer spaces, and so on. These can appear on merges or when one doesn't has all the code style settings set in the IDE.

@bogdan-rosianu bogdan-rosianu added the type:feature New feature or request label May 9, 2022
@bogdan-rosianu bogdan-rosianu self-assigned this May 9, 2022
@iulianpascalau iulianpascalau self-requested a review May 9, 2022 12:58
@mariusmihaic mariusmihaic self-requested a review May 9, 2022 13:01
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ Log scanner @@

go-fmt-may9

================================================================================

  • Known Warnings 15
  • New Warnings 2
  • Known Errors 0
  • New Errors 0
  • Panics 0
    ================================================================================

@codecov-commenter
Copy link

Codecov Report

Merging #4065 (0db3116) into development (4c6761d) will decrease coverage by 0.01%.
The diff coverage is 68.70%.

@@               Coverage Diff               @@
##           development    #4065      +/-   ##
===============================================
- Coverage        75.25%   75.23%   -0.02%     
===============================================
  Files              614      617       +3     
  Lines            82115    82251     +136     
===============================================
+ Hits             61794    61884      +90     
- Misses           15643    15676      +33     
- Partials          4678     4691      +13     
Impacted Files Coverage Δ
trie/trieStorageManager.go 61.58% <ø> (ø)
update/common.go 56.34% <0.00%> (ø)
update/process/metaBlock.go 79.41% <50.00%> (ø)
outport/notifier/httpClient.go 60.00% <60.00%> (ø)
outport/notifier/eventNotifier.go 60.97% <60.97%> (ø)
dataRetriever/txpool/shardedTxPool.go 90.67% <100.00%> (ø)
factory/statusComponents.go 75.17% <100.00%> (+0.17%) ⬆️
outport/factory/notifierFactory.go 100.00% <100.00%> (ø)
outport/factory/outportFactory.go 97.87% <100.00%> (ø)
process/headerCheck/headerIntegrityVerifier.go 93.10% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bab80d6...0db3116. Read the comment docs.

@bogdan-rosianu bogdan-rosianu merged commit 1db0d1e into development May 10, 2022
@bogdan-rosianu bogdan-rosianu deleted the go-fmt-may9 branch May 10, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants