Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix roll back behind final edge case #4081

Merged
merged 4 commits into from
May 18, 2022

Conversation

SebastianMarian
Copy link
Contributor

  • Fixed roll back behind final edge case, when final block hash from fork detector is not the same with the header hash committed even if the nonce is the same

@SebastianMarian SebastianMarian added the type:feature New feature or request label May 16, 2022
@SebastianMarian SebastianMarian self-assigned this May 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4081 (d515f9f) into development (4c6761d) will increase coverage by 0.01%.
The diff coverage is 76.17%.

❗ Current head d515f9f differs from pull request most recent head a697447. Consider uploading reports for the commit a697447 to get more accurate results

@@               Coverage Diff               @@
##           development    #4081      +/-   ##
===============================================
+ Coverage        75.25%   75.27%   +0.01%     
===============================================
  Files              614      617       +3     
  Lines            82115    82320     +205     
===============================================
+ Hits             61794    61964     +170     
- Misses           15643    15667      +24     
- Partials          4678     4689      +11     
Impacted Files Coverage Δ
process/sync/errors.go 0.00% <ø> (ø)
...s/sync/storageBootstrap/metaStorageBootstrapper.go 0.00% <0.00%> (ø)
trie/trieStorageManager.go 61.58% <ø> (ø)
update/common.go 56.34% <0.00%> (ø)
vm/systemSmartContracts/eei.go 75.91% <0.00%> (-0.43%) ⬇️
vm/process/systemVM.go 60.00% <37.50%> (-3.02%) ⬇️
update/process/metaBlock.go 79.41% <50.00%> (ø)
outport/notifier/httpClient.go 60.00% <60.00%> (ø)
outport/notifier/eventNotifier.go 60.97% <60.97%> (ø)
.../sync/storageBootstrap/shardStorageBootstrapper.go 65.82% <96.77%> (+26.73%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f07c3c...a697447. Read the comment docs.

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.

@SebastianMarian SebastianMarian merged commit ed36edf into development May 18, 2022
@SebastianMarian SebastianMarian deleted the fix-roll-back-behind-final-edge-case branch May 18, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants