Added peer miniblocks save after start in epoch #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
May 19, 2022
•
iulianpascalau
commented
- added peer miniblocks save after start in epoch
Codecov Report
@@ Coverage Diff @@
## rc/2022-july #4091 +/- ##
===============================================
Coverage ? 73.66%
===============================================
Files ? 661
Lines ? 85495
Branches ? 0
===============================================
Hits ? 62979
Misses ? 17792
Partials ? 4724 Continue to review full report at Codecov.
|
# Conflicts: # epochStart/bootstrap/interface.go # epochStart/bootstrap/syncValidatorStatus.go
iulianpascalau
changed the title
iulianpascalau
changed the title
sstanculeanu
previously approved these changes
Jun 21, 2022
ssd04
reviewed
Jun 21, 2022
sstanculeanu
previously approved these changes
Jun 22, 2022
ssd04
previously approved these changes
Jun 22, 2022
iulianpascalau
dismissed stale reviews from ssd04 and sstanculeanu
The base branch was changed.
sstanculeanu
previously approved these changes
Jul 7, 2022
ssd04
previously approved these changes
Jul 7, 2022
sstanculeanu
previously approved these changes
Jul 7, 2022
AdoAdoAdo
reviewed
Jul 7, 2022
update/sync/syncMiniBlocks.go
Outdated
| @@ -103,6 +106,14 @@ func (p *pendingMiniBlocks) SyncPendingMiniBlocks(miniBlockHeaders []data.MiniBl | |||
| func (p *pendingMiniBlocks) syncMiniBlocks(listPendingMiniBlocks []data.MiniBlockHeaderHandler, ctx context.Context) error { | |||
| _ = core.EmptyChannel(p.chReceivedAll) | |||
|
|
|||
| // TODO - remove this | |||
There was a problem hiding this comment.
no, removed. Thanks
sstanculeanu
reviewed
Jul 7, 2022
process/block/baseProcess.go
Outdated
| @@ -1267,7 +1267,7 @@ func (bp *baseProcessor) saveBody(body *block.Body, header data.HeaderHandler, h | |||
| if errNotCritical != nil { | |||
| log.Warn("saveBody.Put -> MiniBlockUnit", "error", errNotCritical.Error()) | |||
| } | |||
| log.Trace("saveBody.Put -> MiniBlockUnit", "time", time.Since(startTime)) | |||
| log.Debug("saveBody.Put -> MiniBlockUnit", "time", time.Since(startTime), "hash", miniBlockHash) // TODO revert this to TRACE | |||
There was a problem hiding this comment.
reverted. Thanks
storage/pruning/pruningStorer.go
Outdated
| "used", persisterToUse.epoch, | ||
| "path", ps.dbPath, | ||
| "returning persister", returningPath, | ||
| "stack", string(debug.Stack())) // TODO remove debug.Stack call |
There was a problem hiding this comment.
removed. Thanks
sstanculeanu
approved these changes
Jul 7, 2022
AdoAdoAdo
approved these changes
Jul 7, 2022
ssd04
approved these changes
Jul 7, 2022
iulianpascalau
added
type:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.