EN-12330: export metric erd_are_vm_queries_ready #4097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4097 +/- ##
==========================================
- Coverage 74.82% 74.82% -0.01%
==========================================
Files 609 609
Lines 80936 80938 +2
==========================================
- Hits 60562 60561 -1
- Misses 15737 15739 +2
- Partials 4637 4638 +1
Continue to review full report at Codecov.
|
miiu96
reviewed
May 31, 2022
| @@ -536,6 +536,10 @@ const MetricP2PUnknownPeers = "erd_p2p_unknown_shard_peers" | |||
| // MetricP2PNumConnectedPeersClassification is the metric for monitoring the number of connected peers split on the connection type | |||
| const MetricP2PNumConnectedPeersClassification = "erd_p2p_num_connected_peers_classification" | |||
|
|
|||
| // MetricAreVMQueriesReady will hold the string representation of the boolean that indicated if the node is ready | |||
| // to process VM queries | |||
| const MetricAreVMQueriesReady = "erd_are_vm_queries_ready" | |||
There was a problem hiding this comment.
maybe you can remove the verb from the const name and value
There was a problem hiding this comment.
I would rather keep the naming, as the are prefix resembles a boolean value
sstanculeanu
previously approved these changes
May 31, 2022
bogdan-rosianu
dismissed
sstanculeanu’s stale review
The base branch was changed.
…ot-ready-for-vm-queries
miiu96
approved these changes
Jun 2, 2022
sstanculeanu
approved these changes
Jun 2, 2022
bogdan-rosianu
deleted the
EN-12330-dont-use-node-in-proxy-if-not-ready-for-vm-queries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
export a metric that will tell if the node is ready for processing VM Queries