Staking v4: integration tests for unStake nodes #4121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aking-v4-integration-tests-unstake
mariusmihaic
changed the base branch from
EN-12196-implement-soft-auction
to
EN-12197-staking-v4-save-nodes-config
…aking-v4-integration-tests-unstake # Conflicts: # integrationTests/vm/staking/stakingV4_test.go
miiu96
reviewed
Jun 9, 2022
| for _, blsKey := range nodesData.BLSKeys { | ||
| signature := append([]byte("signature-"), blsKey...) | ||
| //TODO: | ||
| // - Do the same for unJail |
There was a problem hiding this comment.
do not forget to implement the TODO
There was a problem hiding this comment.
Already implemented in #4170
| MinDelegationAmount: big.NewInt(1), | ||
| } | ||
| marshaledData, err := marshaller.Marshal(managementData) | ||
| log.LogIfError(err) |
There was a problem hiding this comment.
instead of logging the error maybe you can pass the t *testing.T in order to stop the execution
There was a problem hiding this comment.
or return error and stop the test where the call happens
There was a problem hiding this comment.
When creating a newTestMetaProcessor I do not have any t *testing.T pointer to pass, so I'll leave it as it is
sstanculeanu
approved these changes
Jun 10, 2022
miiu96
approved these changes
Jun 10, 2022
…aking-v4-integration-tests-unstake
Base automatically changed from
EN-12197-staking-v4-save-nodes-config
to
feat/liquid-staking
June 16, 2022 11:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
TestStakingV4_UnStakeNodestest which tests unstaking nodes along the staking v4 activation chainSaveDelegationManagerConfigtest func which savessystemSmartContracts.DelegationManagementconfig intestscommon/stakingcommon/stakingCommon.goBugfixes
RegisterValidatorKey&AddKeysToWaitingListexecution order to setStakedflag to falsew_prefix ingetWaitingListKeyswhen saving the staking queue in current nodes config in testsRefactor
createSCRsFromStakingSCOutputfunc which generates scrs related to staking instead of "hard-codding" them