Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nil pointer dereference panic fix #4129

Merged
merged 4 commits into from
Jun 2, 2022
Merged

Conversation

iulianpascalau
Copy link
Contributor

@iulianpascalau iulianpascalau commented May 30, 2022

  • started the health service as the first step when creating a node
  • fixed one integration test
  • added mutex protection in interceptors
  • added more metrics in the trie syncer

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2022

Codecov Report

❗ No coverage uploaded for pull request base (rc/2022-update-libs01@17f7132). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 9220214 differs from pull request most recent head 14cde3b. Consider uploading reports for the commit 14cde3b to get more accurate results

@@                   Coverage Diff                    @@
##             rc/2022-update-libs01    #4129   +/-   ##
========================================================
  Coverage                         ?   74.84%           
========================================================
  Files                            ?      609           
  Lines                            ?    80970           
  Branches                         ?        0           
========================================================
  Hits                             ?    60598           
  Misses                           ?    15736           
  Partials                         ?     4636           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17f7132...14cde3b. Read the comment docs.

- added more metrics in the trie syncer
@iulianpascalau iulianpascalau marked this pull request as ready for review June 2, 2022 13:57
@iulianpascalau iulianpascalau changed the title [WIP]Fixes for OOMs Nil pointer dereference panic fix Jun 2, 2022
@raduchis raduchis self-requested a review June 2, 2022 14:29
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.

@iulianpascalau iulianpascalau merged commit fb62fa2 into rc/2022-update-libs01 Jun 2, 2022
@iulianpascalau iulianpascalau deleted the fixes-OOMs branch June 2, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants