Fix latency unit test #4132
Merged
Fix latency unit test #4132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdan-rosianu
previously approved these changes
May 30, 2022
iulianpascalau
requested changes
May 30, 2022
| nonce, round = integrationTests.WaitOperationToBeDone(t, nodes, nrRoundsToPropagateMultiShard, nonce, round, idxProposers) | ||
| time.Sleep(time.Second) | ||
| time.Sleep(2 * time.Second) |
There was a problem hiding this comment.
we have a const for these values
There was a problem hiding this comment.
as found out with @SebastianMarian we should change the handleProcessMiniBlockInit as following:
func (tc *transactionCoordinator) handleProcessMiniBlockInit(miniBlockHash []byte) int {
snapshot := tc.accounts.JournalLen()
tc.InitProcessedTxsResults(miniBlockHash)
tc.gasHandler.Reset(miniBlockHash)
return snapshot
}
iulianpascalau
approved these changes
May 31, 2022
bogdan-rosianu
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time.Sleepperiod