Fix genesis indexing txs order #4156
Conversation
genesis/parsing/accountsParser.go
Outdated
| txs []coreData.TransactionHandler, | ||
| txsPoolPerShard map[uint32]*indexer.Pool, | ||
| ) (*block.MiniBlock, error) { | ||
| txHashes := make([][]byte, 0) |
There was a problem hiding this comment.
txHashes := make([][]byte, 0, len(txs))
genesis/parsing/accountsParser.go
Outdated
| @@ -362,9 +362,35 @@ func createMiniBlocks(shardIDs []uint32, blockType block.Type) []*block.MiniBloc | |||
| return miniBlocks | |||
| } | |||
|
|
|||
| func (ap *accountsParser) setMintingTxsPoolAndMiniBlock( | |||
There was a problem hiding this comment.
maybe you can change the name of the function
putMintingTxsInPoolAndCreateMiniblock
Codecov Report
@@ Coverage Diff @@
## rc/2022-june #4156 +/- ##
=============================================
Coverage 75.27% 75.27%
=============================================
Files 617 617
Lines 82393 82410 +17
=============================================
+ Hits 62023 62036 +13
- Misses 15681 15683 +2
- Partials 4689 4691 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
System test passed. Errors and warnings are safe .
@@ Log scanner @@
fix-genesis-indexing-txs-order
================================================================================
- Known Warnings 22
- New Warnings 5
- Known Errors 0
- New Errors 2
- Panics 0
================================================================================
Set minting transactions from genesis to be set in the first miniblock, handled by metachain.