Added an endpoint that provides data from the genesis file #4172
Conversation
bogdan-rosianu
changed the title
api/groups/networkGroup.go
Outdated
| func (ng *networkGroup) getGenesisBalances(c *gin.Context) { | ||
| start := time.Now() | ||
| genesisBalances, err := ng.getFacade().GetGenesisBalances() | ||
| log.Debug(fmt.Sprintf("GetGenesisBalances took %s", time.Since(start))) |
There was a problem hiding this comment.
consider refactoring all these calls as following:
log.Debug("API call: GetGenesisBalances", "duration", time.Since(start))There was a problem hiding this comment.
done for the entire groups package
| @@ -64,6 +65,7 @@ func (psh *PersistentStatusHandler) initMap() { | |||
| psh.persistentMetrics.Store(common.MetricTotalSupply, zeroString) | |||
| psh.persistentMetrics.Store(common.MetricTotalFees, zeroString) | |||
| psh.persistentMetrics.Store(common.MetricDevRewardsInEpoch, zeroString) | |||
| psh.persistentMetrics.Store(common.MetricGenesisBlockHash, emptyString) | |||
There was a problem hiding this comment.
This is a bit misleading: we actually had 4 genesis block hashes
Where do we set this metric other than the empty string?
There was a problem hiding this comment.
forgotten code. removed that metric. thanks
Codecov Report
@@ Coverage Diff @@
## feat/rosetta #4172 +/- ##
===============================================
Coverage ? 75.29%
===============================================
Files ? 626
Lines ? 82690
Branches ? 0
===============================================
Hits ? 62258
Misses ? 15715
Partials ? 4717 Continue to review full report at Codecov.
|
| @@ -414,6 +421,27 @@ func (ng *networkGroup) getGenesisNodesConfig(c *gin.Context) { | |||
| shared.RespondWith(c, http.StatusOK, gin.H{"nodes": nc}, "", shared.ReturnCodeSuccess) | |||
| } | |||
|
|
|||
| // getGenesisBalances return genesis balances configuration | |||
There was a problem hiding this comment.
Typo (returns) / (comment can also be dropped).
| return nil, err | ||
| } | ||
| if len(initialAccounts) == 0 { | ||
| return nil, ErrNilGenesisBalances |
There was a problem hiding this comment.
Perhaps "empty" instead of "nil" (works either way, though).
schimih
changed the title
added the
/network/genesis-balancesendpoint that exposes the content of thegenesis.jsonfile