-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added integration test for relayed tx v2 #4229
Conversation
Codecov Report
@@ Coverage Diff @@
## development #4229 +/- ##
===============================================
+ Coverage 75.25% 75.85% +0.60%
===============================================
Files 614 645 +31
Lines 82115 85221 +3106
===============================================
+ Hits 61794 64643 +2849
- Misses 15643 15785 +142
- Partials 4678 4793 +115
Continue to review full report at Codecov.
|
relayedTx := createRelayedTxV2(txDispatcherNode.EconomicsData, relayer, userTx, gasLimit) | ||
|
||
_, err := txDispatcherNode.SendTransaction(relayedTx) | ||
if err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't an assert for nil useful here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the same behavior as for the relayed tx integration test. I assume it is enough to only print the error if any. the test would fail anyway if this doesn't work
added an integration test for relayed tx v2, which illustrates how such a transaction should be made + ensure the functionality