Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added integration test for relayed tx v2 #4229

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

bogdan-rosianu
Copy link
Contributor

added an integration test for relayed tx v2, which illustrates how such a transaction should be made + ensure the functionality

@bogdan-rosianu bogdan-rosianu added the type:feature New feature or request label Jun 27, 2022
@bogdan-rosianu bogdan-rosianu self-assigned this Jun 27, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4229 (c61130e) into development (4c6761d) will increase coverage by 0.60%.
The diff coverage is 91.65%.

❗ Current head c61130e differs from pull request most recent head 92153b5. Consider uploading reports for the commit 92153b5 to get more accurate results

@@               Coverage Diff               @@
##           development    #4229      +/-   ##
===============================================
+ Coverage        75.25%   75.85%   +0.60%     
===============================================
  Files              614      645      +31     
  Lines            82115    85221    +3106     
===============================================
+ Hits             61794    64643    +2849     
- Misses           15643    15785     +142     
- Partials          4678     4793     +115     
Impacted Files Coverage Δ
dataRetriever/interface.go 12.12% <ø> (ø)
epochStart/bootstrap/baseStorageHandler.go 61.19% <ø> (ø)
factory/bootstrapComponentsHandler.go 61.40% <0.00%> (ø)
factory/consensusComponentsHandler.go 60.56% <0.00%> (+4.71%) ⬆️
factory/cryptoComponentsHandler.go 66.21% <0.00%> (ø)
factory/dataComponentsHandler.go 71.08% <0.00%> (ø)
factory/heartbeatComponentsHandler.go 64.17% <0.00%> (ø)
factory/networkComponentsHandler.go 78.49% <0.00%> (ø)
factory/stateComponentsHandler.go 72.04% <0.00%> (ø)
factory/statusComponentsHandler.go 16.45% <0.00%> (ø)
... and 153 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb767dd...92153b5. Read the comment docs.

relayedTx := createRelayedTxV2(txDispatcherNode.EconomicsData, relayer, userTx, gasLimit)

_, err := txDispatcherNode.SendTransaction(relayedTx)
if err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't an assert for nil useful here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the same behavior as for the relayed tx integration test. I assume it is enough to only print the error if any. the test would fail anyway if this doesn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants