improve api call actions logs #4239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssd04
previously approved these changes
Jun 29, 2022
|
Maybe you should check also in the |
Checked. No occurrence |
miiu96
previously approved these changes
Jun 29, 2022
bogdan-rosianu
dismissed stale reviews from gabi-vuls, miiu96, and ssd04
The base branch was changed.
miiu96
approved these changes
Jun 30, 2022
ssd04
approved these changes
Jun 30, 2022
iulianpascalau
approved these changes
Jun 30, 2022
| const thresholdMinAPICallDurationToLog = 200 * time.Millisecond | ||
|
|
||
| // LogAPIActionDurationIfNeeded will log the duration of an action triggered by an API call if it's above a threshold | ||
| func LogAPIActionDurationIfNeeded(startTime time.Time, action string) { |
There was a problem hiding this comment.
no unit tests for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this PR, all durations of certain API actions would have been logged. this PR unifies the logging via a single function which only logs if the duration is above a threshold