Extra data in block structure api and indexer #4308
Conversation
There was a problem hiding this comment.
@@ Log scanner @@
indexer-extra-data-block-structure
================================================================================
- Known Warnings 18
- New Warnings 0
- Known Errors 0
- New Errors 3
- Panics 26
================================================================================
miiu96
changed the title
Codecov Report
@@ Coverage Diff @@
## rc/2022-july #4308 +/- ##
===============================================
Coverage ? 73.69%
===============================================
Files ? 663
Lines ? 86191
Branches ? 0
===============================================
Hits ? 63515
Misses ? 17914
Partials ? 4762 Continue to review full report at Codecov.
|
node/external/blockAPI/metaBlock.go
Outdated
| } | ||
|
|
||
| epochStartShardsData := metaBlock.EpochStart.LastFinalizedHeaders | ||
| apiBlock.EpochStartShardsData = make([]*api.EpochStartShardData, 0, len(metaBlock.EpochStart.LastFinalizedHeaders)) |
There was a problem hiding this comment.
could have used len(epochStartShardsData)
node/external/blockAPI/baseBlock.go
Outdated
|
|
||
| func addScheduledInfoInBlock(header data.HeaderHandler, apiBlock *api.Block) { | ||
| additionalData := header.GetAdditionalData() | ||
| if additionalData == nil { |
There was a problem hiding this comment.
check.IfNil(additionalData) as header.GetAdditionalData() will return an interface
| } | ||
| } | ||
|
|
||
| func bigIntToStr(value *big.Int) string { |
| return apiMetaBlock, nil | ||
| } | ||
|
|
||
| func addStartOfEpochInfoInBlock(metaBlock *block.MetaBlock, apiBlock *api.Block) { |
node/external/blockAPI/metaBlock.go
Outdated
| } | ||
|
|
||
| if len(epochStartShardData.PendingMiniBlockHeaders) == 0 { | ||
| apiBlock.EpochStartShardsData = append(apiBlock.EpochStartShardsData, shardData) |
There was a problem hiding this comment.
move this outside the if branch and remove L222
| @@ -418,7 +418,26 @@ func TestMetaAPIBlockProcessor_GetBlockByRound_GetBlockByNonce_EpochStartBlock(t | |||
| }, | |||
| }, | |||
| EpochStart: block.EpochStart{ | |||
| LastFinalizedHeaders: []block.EpochStartShardData{{}}, | |||
| LastFinalizedHeaders: []block.EpochStartShardData{{ | |||
There was a problem hiding this comment.
Please do:
- add one more finalized header
- add one more miniblock header in each finalized header
There was a problem hiding this comment.
@@ Log scanner @@
indexer-extra-data-block-structure
================================================================================
- Known Warnings 14
- New Warnings 0
- Known Errors 0
- New Errors 0
- Panics 0
================================================================================
miiu96
added
area:node-api
blockstructure)