Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove destroy persisters calls #4393

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

bogdan-rosianu
Copy link
Contributor

Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)

  • if a persister could have not been created (for example, when extra tweaking the configuration and the system's ulimit was too low), all the opened DBs would have been destroyed, which should only be valid if the databases are created (not opened)

Proposed Changes

  • remove the code block that called DestroyUnit()

Testing procedure

  • specific scenario already tested and validated
  • these changes don't affect other storage operations

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.

@gabi-vuls gabi-vuls merged commit ec5c6e2 into rc/2022-july Aug 24, 2022
@gabi-vuls gabi-vuls deleted the remove-destroy-persisters-calls branch August 24, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants