Auto liquidity cleanup fixes #4399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raduchis
requested changes
Aug 26, 2022
go.mod
Outdated
| @@ -12,7 +12,7 @@ require ( | |||
| github.com/ElrondNetwork/elrond-go-core v1.1.19 | |||
| github.com/ElrondNetwork/elrond-go-crypto v1.0.1 | |||
| github.com/ElrondNetwork/elrond-go-logger v1.0.7 | |||
| github.com/ElrondNetwork/elrond-vm-common v1.3.14 | |||
| github.com/ElrondNetwork/elrond-vm-common v1.3.15-0.20220825161922-b9b0bd5da6e0 | |||
There was a problem hiding this comment.
please create a proper 1.3.15 release
There was a problem hiding this comment.
used the proper release.
I cannot target it towards rc/2022-july since the branch cannot be tested without PR #4395
The target branch will automatically be updated after it is merged. fyi @iulianpascalau
iulianpascalau
requested changes
Aug 26, 2022
Base automatically changed from
EN-12987-add-multiple-allowed-addresses
to
rc/2022-july
August 28, 2022 14:19
Codecov Report
@@ Coverage Diff @@
## rc/2022-july #4399 +/- ##
===============================================
Coverage ? 73.91%
===============================================
Files ? 677
Lines ? 86864
Branches ? 0
===============================================
Hits ? 64207
Misses ? 17863
Partials ? 4794 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
raduchis
approved these changes
Aug 28, 2022
iulianpascalau
approved these changes
Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)
Proposed Changes
Testing procedure