P2P signing on direct send #4466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the p2p network messenger - added exception in consensus interceptor to not allow messages without signature
Codecov ReportBase: 73.87% // Head: 73.94% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feat/optimise-consensus-sigcheck #4466 +/- ##
====================================================================
+ Coverage 73.87% 73.94% +0.07%
====================================================================
Files 693 680 -13
Lines 88459 87154 -1305
====================================================================
- Hits 65349 64450 -899
+ Misses 18182 17887 -295
+ Partials 4928 4817 -111
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ssd04
reviewed
Sep 15, 2022
Comment on lines
+263
to
+267
| buff, err := mes.Marshal() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
There was a problem hiding this comment.
in libp2p there is the SignPrefix that's being added, should we think about it here, while we construct the message?
p2p/libp2p/directSender_test.go
Outdated
Comment on lines
70
to
71
| func TestNewDirectSender(t *testing.T) { | ||
| t.Run("nil context", func(t *testing.T) { |
There was a problem hiding this comment.
done in all tests
AdoAdoAdo
reviewed
Sep 15, 2022
AdoAdoAdo
reviewed
Sep 15, 2022
…irect-send # Conflicts: # p2p/libp2p/export_test.go # p2p/libp2p/netMessenger.go # p2p/libp2p/netMessenger_test.go
ssd04
previously approved these changes
Sep 15, 2022
AdoAdoAdo
reviewed
Sep 15, 2022
p2p/libp2p/directSender.go
Outdated
| @@ -27,6 +27,8 @@ var _ p2p.DirectSender = (*directSender)(nil) | |||
|
|
|||
| const timeSeenMessages = time.Second * 120 | |||
| const maxMutexes = 10000 | |||
| const signPrefix = "en-directsend:" | |||
There was a problem hiding this comment.
maybe use the same prefix as in libp2p so that we can treat broadcast and direct send messages similarly.
There was a problem hiding this comment.
fixed, reused pubsub.SignPrefix
sstanculeanu
previously approved these changes
Sep 15, 2022
AdoAdoAdo
previously approved these changes
Sep 15, 2022
ssd04
previously approved these changes
Sep 15, 2022
iulianpascalau
dismissed stale reviews from AdoAdoAdo and sstanculeanu
via
3a50d66
sstanculeanu
approved these changes
Sep 19, 2022
ssd04
approved these changes
Sep 19, 2022
AdoAdoAdo
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)
Proposed Changes
Testing procedure