Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test consensus signing #4506

Merged

Conversation

ssd04
Copy link
Contributor

@ssd04 ssd04 commented Sep 23, 2022

Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)

  • Integration test for consensus signing

Proposed Changes

  • added new integration test in consensus, with changes regarding multiSigner and signing components
  • use real components for singing in consensus integration tests, instead of using mocks
  • fix issue in crypto components where private key bytes was not set

Testing procedure

  • N/A

@ssd04 ssd04 marked this pull request as ready for review September 26, 2022 08:14
sstanculeanu
sstanculeanu previously approved these changes Sep 26, 2022
- fix unit tests after refactoring
- added TODOs for consensus signing integration test
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (feat/optimise-consensus-sigcheck@41d4ff2). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 7dba9e5 differs from pull request most recent head 34b0c36. Consider uploading reports for the commit 34b0c36 to get more accurate results

Additional details and impacted files
@@                         Coverage Diff                         @@
##             feat/optimise-consensus-sigcheck    #4506   +/-   ##
===================================================================
  Coverage                                    ?   71.20%           
===================================================================
  Files                                       ?      663           
  Lines                                       ?    86048           
  Branches                                    ?        0           
===================================================================
  Hits                                        ?    61267           
  Misses                                      ?    20273           
  Partials                                    ?     4508           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssd04 ssd04 merged commit bc11595 into feat/optimise-consensus-sigcheck Sep 26, 2022
@ssd04 ssd04 deleted the integration-test-consensus-signing branch September 26, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants