Start snapshot after restart fix #4551
Conversation
| @@ -384,6 +384,14 @@ func (nr *nodeRunner) executeOneComponentCreationCycle( | |||
| return true, err | |||
| } | |||
|
|
|||
| selfId := managedBootstrapComponents.ShardCoordinator().SelfId() | |||
There was a problem hiding this comment.
please re-check this. On rc/v1.4.0 we do not have this call here
There was a problem hiding this comment.
in rc/v1.4.0 these are called in the addSyncersToAccountsDB function after setting the trie syncers.
| @@ -160,17 +154,16 @@ func checkArgsAccountsDB(args ArgsAccountsDB) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func startSnapshotAfterRestart(adb AccountsAdapter, args ArgsAccountsDB) { | |||
| tsm := args.Trie.GetStorageManager() | |||
| func startSnapshotAfterRestart(adb AccountsAdapter, tsm common.StorageManager, processingMode common.NodeProcessingMode) { | |||
There was a problem hiding this comment.
checked the file with v1.4.0, looks good 👍
| return adb, nil | ||
| } | ||
|
|
||
| // StartSnapshotIfNeeded starts the snapshot if the previous snapshot process was not fully completed |
There was a problem hiding this comment.
checked with the rc/v1.4.0, looks good
Codecov ReportBase: 73.95% // Head: 73.91% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4551 +/- ##
==========================================
- Coverage 73.95% 73.91% -0.05%
==========================================
Files 681 681
Lines 87162 87170 +8
==========================================
- Hits 64462 64432 -30
- Misses 17883 17921 +38
Partials 4817 4817
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Description of the reasoning behind the pull request
Proposed Changes
Testing procedure