Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test multi key #4620

Merged
merged 7 commits into from Dec 2, 2022
Merged

Conversation

iulianpascalau
Copy link
Contributor

Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)

  • added integration test to prove the multi-key feature works as expected

Proposed Changes

  • added integration test to prove the multi-key feature works as expected

Testing procedure

  • N/A

@iulianpascalau iulianpascalau changed the base branch from master to feat/multisigner October 21, 2022 09:34
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2022

Codecov Report

❗ No coverage uploaded for pull request base (feat/multikey@f7b1a3c). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##             feat/multikey    #4620   +/-   ##
================================================
  Coverage                 ?   70.87%           
================================================
  Files                    ?      651           
  Lines                    ?    85404           
  Branches                 ?        0           
================================================
  Hits                     ?    60533           
  Misses                   ?    20342           
  Partials                 ?     4529           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

iulianpascalau and others added 6 commits October 24, 2022 09:52
# Conflicts:
#	integrationTests/testInitializer.go
…into integration-test-multi-key

# Conflicts:
#	integrationTests/testConsensusNode.go
#	integrationTests/testHeartbeatNode.go
#	integrationTests/testInitializer.go
#	integrationTests/testProcessorNode.go
#	integrationTests/testProcessorNodeWithCoordinator.go
#	integrationTests/testProcessorNodeWithMultisigner.go
@iulianpascalau iulianpascalau changed the title [DO NOT REVIEW YET]Integration test multi key Integration test multi key Nov 30, 2022
@iulianpascalau iulianpascalau marked this pull request as ready for review November 30, 2022 12:14
@iulianpascalau iulianpascalau self-assigned this Nov 30, 2022
@iulianpascalau iulianpascalau merged commit 5f9b97f into feat/multikey Dec 2, 2022
@iulianpascalau iulianpascalau deleted the integration-test-multi-key branch December 2, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants