Pseudo slashing fixes

[ssd04]

Reasoning behind the pull request

• Error on creating the aggregated signature on leader was not treated accordingly. Since the sig share is not checked by each node separately, it can happen that an invalid format sig share is provided, so signature aggregation will fail

Proposed changes

• handler invalid signers similar as in the verification case

Testing procedure

• N/A

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

• was the PR targeted to the correct branch?
• if this is a larger feature that probably needs more than one PR, is there a feat branch created?
• if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (feat/optimise-consensus-sigcheck@91440ea). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@                         Coverage Diff                         @@
##             feat/optimise-consensus-sigcheck    #4630   +/-   ##
===================================================================
  Coverage                                    ?   71.23%           
===================================================================
  Files                                       ?      664           
  Lines                                       ?    86296           
  Branches                                    ?        0           
===================================================================
  Hits                                        ?    61474           
  Misses                                      ?    20305           
  Partials                                    ?     4517           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[SebastianMarian]

I think you can extract L301-L328 in a separate method which will return bitmap, sig and err, actually you can directly return from there sr.handleInvalidSignersOnAggSigFail(), and make the code easier to read there without so much if else levels. Here you should have only something like this:

bitmap, sig, err := sr.aggregateSigsAndHandleInvalidSigners(bitmap)
if err != nil {
	log.Debug("doEndRoundJobByLeader.aggregateSigsAndHandleInvalidSigners", "error", err.Error())
	return false
}

[SebastianMarian]

.verifyNodesOnAggSigFail

[AdoAdoAdo]

no additional comments