Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable epochs handler to data trie #4680

Merged

Conversation

BeniaminDrasovean
Copy link
Contributor

Reasoning behind the pull request

  • propagate enableEpochsHandler to userAccount

Proposed changes

  • create a new flag for the activation of data tries auto-balancing
  • add some parameters to the account factory instead of the Create() method
  • propagate enableEpochsHandler to userAccount

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

Base: 70.75% // Head: 70.74% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (39467c0) compared to base (fc8ec3e).
Patch coverage: 58.44% of modified lines in pull request are covered.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           feat/balance-data-tries    #4680      +/-   ##
===========================================================
- Coverage                    70.75%   70.74%   -0.02%     
===========================================================
  Files                          630      630              
  Lines                        83365    83413      +48     
===========================================================
+ Hits                         58987    59008      +21     
- Misses                       19965    19990      +25     
- Partials                      4413     4415       +2     
Impacted Files Coverage Δ
factory/processing/processComponents.go 0.00% <0.00%> (ø)
factory/state/stateComponents.go 0.00% <0.00%> (ø)
state/errors.go 50.00% <ø> (ø)
update/genesis/base.go 23.33% <0.00%> (-0.81%) ⬇️
update/genesis/import.go 13.35% <9.09%> (+0.01%) ⬆️
genesis/process/genesisBlockCreator.go 17.11% <66.66%> (+1.00%) ⬆️
common/enablers/enableEpochsHandler.go 74.04% <100.00%> (+0.19%) ⬆️
common/enablers/epochFlags.go 92.39% <100.00%> (+0.08%) ⬆️
process/block/baseProcess.go 73.43% <100.00%> (+0.09%) ⬆️
state/accountsDB.go 79.01% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeniaminDrasovean BeniaminDrasovean added the ignore-for-release-notes Do not include item in release notes label Nov 10, 2022
@ssd04 ssd04 self-requested a review November 10, 2022 13:19
state/factory/accountCreator.go Outdated Show resolved Hide resolved
state/userAccount.go Outdated Show resolved Hide resolved
state/userAccount.go Show resolved Hide resolved
integrationTests/testInitializer.go Outdated Show resolved Hide resolved
state/peerAccount.go Show resolved Hide resolved
cmd/node/config/enableEpochs.toml Outdated Show resolved Hide resolved
state/disabled/disabledDataTrieHandler.go Show resolved Hide resolved
state/disabled/disabledTrackableDataTrie_test.go Outdated Show resolved Hide resolved
state/userAccount.go Show resolved Hide resolved
@BeniaminDrasovean BeniaminDrasovean merged commit 02f9e7d into feat/balance-data-tries Nov 11, 2022
@BeniaminDrasovean BeniaminDrasovean deleted the enable-epochs-handler-to-data-trie branch November 11, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants