Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove key size from total leaf size computation #4729

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

BeniaminDrasovean
Copy link
Contributor

Reasoning behind the pull request

  • Taking the key into consideration when computing data size is backwards incompatible

Proposed changes

  • Revert some changes from previous PR

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@BeniaminDrasovean BeniaminDrasovean added the ignore-for-release-notes Do not include item in release notes label Nov 23, 2022
@BeniaminDrasovean BeniaminDrasovean self-assigned this Nov 23, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (feat/balance-data-tries@d30b794). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             feat/balance-data-tries    #4729   +/-   ##
==========================================================
  Coverage                           ?   70.74%           
==========================================================
  Files                              ?      632           
  Lines                              ?    83536           
  Branches                           ?        0           
==========================================================
  Hits                               ?    59096           
  Misses                             ?    20023           
  Partials                           ?     4417           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeniaminDrasovean BeniaminDrasovean changed the title add key size to total leaf size computation remove key size from total leaf size computation Nov 23, 2022
@BeniaminDrasovean BeniaminDrasovean merged commit 32a03f4 into feat/balance-data-tries Nov 25, 2022
@BeniaminDrasovean BeniaminDrasovean deleted the fix-leaf-size-check branch November 25, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants