Feat/multikey #4741
Merged
Feat/multikey #4741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-support Multisigner: added support in network messenger
…kage + new struct
Multisigner: added keysHolder struct
Multisigner: keys holder redundancy support
# Conflicts: # p2p/libp2p/netMessenger_test.go
…22.08.12 Update multisigner dev 2022.08.12
Integrate named identities
Update dev 2022.08.27
…ikey-2022.12.19 Merge rc v1.5.0 feat multikey 2022.12.19
# Conflicts: # cmd/node/main.go # consensus/broadcast/commonMessenger_test.go # consensus/broadcast/metaChainMessenger_test.go # consensus/broadcast/shardChainMessenger_test.go # consensus/mock/consensusDataContainerMock.go # consensus/spos/bls/blsWorker_test.go # consensus/spos/bls/subroundEndRound_test.go # consensus/spos/consensusCore.go # consensus/spos/consensusState.go # consensus/spos/consensusState_test.go # consensus/spos/interface.go # consensus/spos/roundConsensus_test.go # consensus/spos/subround_test.go # factory/crypto/cryptoComponents.go # factory/crypto/cryptoComponentsHandler.go # factory/crypto/cryptoComponents_test.go # factory/crypto/export_test.go # factory/crypto/signingHandler.go # factory/crypto/signingHandler_test.go # factory/interface.go # factory/mock/cryptoComponentsMock.go # go.mod # go.sum # heartbeat/interface.go # heartbeat/sender/heartbeatSender.go # heartbeat/sender/peerAuthenticationSender.go # integrationTests/consensus/consensus_test.go # integrationTests/mock/cryptoComponentsStub.go # integrationTests/testConsensusNode.go # integrationTests/testInitializer.go # node/mock/factory/cryptoComponentsStub.go
Merge feat multikey 2023.01.25
added IsMultiKey method to managedPeersHolder interface added few extra tests
# Conflicts: # cmd/node/config/config.toml # consensus/broadcast/commonMessenger_test.go # consensus/broadcast/metaChainMessenger_test.go # consensus/broadcast/shardChainMessenger_test.go # consensus/mock/messengerStub.go # consensus/mock/mockTestInitializer.go # go.mod # go.sum # integrationTests/factory/componentsHelper.go # integrationTests/testConsensusNode.go
Update rc v1.5.0 2023.02.20
…e_selection Fix storage pruning node type selection
…23.02.24 Update multikey rc v1.6.0 2023.02.24
# Conflicts: # epochStart/bootstrap/metaStorageHandler.go # epochStart/bootstrap/metaStorageHandler_test.go # epochStart/bootstrap/process.go # epochStart/bootstrap/shardStorageHandler.go # epochStart/bootstrap/shardStorageHandler_test.go # factory/data/dataComponents.go # factory/processing/processComponents.go # integrationTests/multiShard/endOfEpoch/startInEpoch/startInEpoch_test.go
Update rc v1.6.0 2023.03.02
Proper release for feat multikey
gabi-vuls
approved these changes
Mar 6, 2023
BeniaminDrasovean
approved these changes
Mar 6, 2023
raduchis
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
This feature added multikey support that will enable the node to sign on behalf of more than one key. To work, a multikey node will be required for each
shard of the chain (including the metachain) and the exact set of keys should be given to all the nodes.
A detailed description of the feature is available here https://docs.multiversx.com/validators/key-management/multikey-nodes
This feature does not require a flag and is known to not induce backward compatibility issues. This feature does not change API routes.
In terms of the configuration files, we have this change list:
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?