Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing call to decrease rating into peers rating handler #4780

Merged
merged 4 commits into from Dec 13, 2022

Conversation

sstanculeanu
Copy link
Contributor

@sstanculeanu sstanculeanu commented Dec 8, 2022

Reasoning behind the pull request

  • call to decrease peer rating is missing

Proposed changes

  • add call to decrease rating and add integration test

Testing procedure

  • standard system test + integration test[coming in next PR]

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

sstanculeanu and others added 2 commits December 2, 2022 18:53
…decrease_call

Add missing call to DecreaseRating on peersRatingHandler
@sstanculeanu sstanculeanu added type:bug Something isn't working low prio not critical - to be solved with low prio DO NOT MERGE area:processing interested:protocol complexity:medium labels Dec 8, 2022
@sstanculeanu sstanculeanu self-assigned this Dec 8, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 70.80% // Head: 70.80% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (348a321) compared to base (1dbcfff).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.5.0    #4780      +/-   ##
=============================================
- Coverage      70.80%   70.80%   -0.01%     
=============================================
  Files            644      644              
  Lines          84817    84818       +1     
=============================================
- Hits           60058    60057       -1     
- Misses         20256    20257       +1     
- Partials        4503     4504       +1     
Impacted Files Coverage Δ
...solvers/topicResolverSender/topicResolverSender.go 100.00% <100.00%> (ø)
common/pidQueue.go 93.33% <0.00%> (-3.34%) ⬇️
state/accountsDB.go 78.89% <0.00%> (ø)
node/metrics/metrics.go 65.94% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sstanculeanu sstanculeanu changed the base branch from rc/v1.5.0 to feat/fix-peers-rating-handler December 13, 2022 12:54
@sstanculeanu sstanculeanu changed the title Fix peers rating handler and add integration test Fix missing call to decrease rating into peers rating handler Dec 13, 2022
…nto fix_peers_rating_handler

# Conflicts:
#	dataRetriever/resolvers/topicResolverSender/topicResolverSender_test.go
@sstanculeanu sstanculeanu marked this pull request as ready for review December 13, 2022 13:01
@sstanculeanu sstanculeanu merged commit 9406531 into feat/fix-peers-rating-handler Dec 13, 2022
@sstanculeanu sstanculeanu deleted the fix_peers_rating_handler branch December 13, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:processing complexity:medium interested:protocol low prio not critical - to be solved with low prio type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants