Peers rating handler integration test #4781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on peersRatingHandler and added integration test for peersRatingHandler
sstanculeanu
added
low prio
SebastianMarian
previously approved these changes
Dec 8, 2022
Base automatically changed from
fix_peers_rating_handler
to
feat/fix-peers-rating-handler
December 13, 2022 13:09
…nto peers_rating_handler_integration_test # Conflicts: # go.mod # go.sum # integrationTests/testProcessorNode.go # node/metrics/metrics.go
iulianpascalau
approved these changes
Dec 13, 2022
| assert.Equal(t, int32(-100), initialMaliciousRating.Rating) | ||
| testTimestampsForNotRespondingNode(t, initialMaliciousRating.TimestampLastResponseFromPid, initialMaliciousRating.TimestampLastRequestToPid, 0) | ||
|
|
||
| // Add header to the malicious node's cache and remove it from the resolver's cache |
There was a problem hiding this comment.
L98 - L116 also test that requests are still performed towards the low rating peer 👍
| }) | ||
| appStatusHandler := args.AppStatusHandler | ||
| if check.IfNil(args.AppStatusHandler) { | ||
| appStatusHandler = TestAppStatusHandler |
There was a problem hiding this comment.
Is this OK? Having the same pointer TestAppStatusHandler will make debugging incredibly hard because nodes will tend to alter the same instance. Maybe not for this PR I will consider removing this TestAppStatusHandler and create different instances always.
There was a problem hiding this comment.
indeed, shouldn't use the same pointer
SebastianMarian
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?