Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MetricReceivedProposedBlock overflow #4831

Merged
merged 4 commits into from Dec 24, 2022

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • there were situations when the MetricReceivedProposedBlock was improperly computed

Proposed changes

  • fix MetricReceivedProposedBlock overflow by disallowing a negative value

Testing procedure

  • standard system test + system test without transactions

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

❗ No coverage uploaded for pull request base (rc/v1.4.0@a3ca9d0). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             rc/v1.4.0    #4831   +/-   ##
============================================
  Coverage             ?   70.74%           
============================================
  Files                ?      647           
  Lines                ?    85115           
  Branches             ?        0           
============================================
  Hits                 ?    60214           
  Misses               ?    20368           
  Partials             ?     4533           
Impacted Files Coverage Δ
consensus/spos/worker.go 82.08% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

bogdan-rosianu
bogdan-rosianu previously approved these changes Dec 22, 2022
Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed

@iulianpascalau iulianpascalau merged commit 988b730 into rc/v1.4.0 Dec 24, 2022
@iulianpascalau iulianpascalau deleted the fix-metric-counter-overflow branch December 24, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants